[PATCH] D103539: WIP: try to repair RISCV handling of paired relocations

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp:396
     return;
+
   MCContext &Ctx = Asm.getContext();
----------------
jrtc27 wrote:
> compnerd wrote:
> > jrtc27 wrote:
> > > Please don't "fix" unrelated whitespace
> > Sure, from a final patch perhaps, but when working on something its very helpful.
> Only locally. For reviewing it's a nuisance, so please remove them from the review.
This isn't meant for reviewing yet :) - its marked as a WIP.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVELFStreamer.cpp:61
+  MCA.setRelaxAll(STI.getFeatureBits()[RISCV::FeatureRelax]);
 }
 MCELFStreamer &RISCVTargetELFStreamer::getStreamer() {
----------------
jrtc27 wrote:
> Why has this suddenly appeared in version 2?
This change isn't really ready for review yet.  I wanted to share it with @MaskRay so I put it here as it is where it is going to end up.  I'm still working through the changes, so expect a lot of major changes.  Thats also why there is no one tagged on the diff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103539/new/

https://reviews.llvm.org/D103539