[PATCH] D103641: [scudo] Rework Vector/String

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/vector.h:94
+  T *Data = nullptr;
+  u8 LocalData[256] = {};
+  uptr CapacityBytes = 0;
----------------
hctim wrote:
> Is stack size a problem?
> 
> If so, we could typedef this (`template <typename T, int StackBufferBytes = 256> class VectorNoCtor`) and in places where we know the upper bound, we can bound the stack buffer size as well.
Apparently stack is 1 page as well. 256 should be fine, but I will revisit with `CanGrow` as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103641/new/

https://reviews.llvm.org/D103641