[PATCH] D103261: [AMDGPU] Increase alignment of LDS globals if necessary before LDS lowering.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPULDSUtils.cpp:156
+    // Increase the alignment of GV, if it is under-aligned.
+    Align Alignment = AMDGPU::getAlign(DL, GV);
+    TypeSize GVSize = DL.getTypeAllocSize(GV->getValueType());
----------------
I think this is a bad helper and it would be clearer to explicitly query the GV alignment


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103261/new/

https://reviews.llvm.org/D103261