[PATCH] D103415: [BuildLibCalls] Properly set ABI attributes on arguments

Thu Jun 3 14:10:19 PDT 2021

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

> There's some horrifying index manipulation involving unsigned overflow that I had to avoid by checking if either AttributeList is empty.

By horrifying, surely you mean far too clever for anyone's best interests. =D

> It'd be nice to not have AttributeList::AttrIndex::FunctionIndex = ~0U.

I had a patch to do that back in 2017, but the reviewers at the time felt it was too risky:
https://reviews.llvm.org/D32819#749163
https://reviews.llvm.org/D32819?id=98222#inline-286125

We could try again, but it has the potential to break frontends in ways that are hard to debug.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103415/new/

https://reviews.llvm.org/D103415