[PATCH] D103634: [Constants][PowerPC] Check exactlyValue for ppc_fp128 in isNullValue

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 3 12:53:00 PDT 2021


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM with one minor comment.



================
Comment at: llvm/lib/IR/Constants.cpp:96
+    if (CFP->getType()->isPPC_FP128Ty())
+      return CFP->isExactlyValue(+0.0);
     return CFP->isZero() && !CFP->isNegative();
----------------
We can use isExactlyValue() for all floating-point types; no reason to have two separate codepaths.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103634/new/

https://reviews.llvm.org/D103634



More information about the llvm-commits mailing list