[PATCH] D103082: [AArch64][SVE] Improve codegen for dupq SVE ACLE intrinsics

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9068
+        VecOps.push_back(llvm::ConstantInt::get(
+            EltTy, cast<ConstantInt>(Ops[I])->getZExtValue()));
+      else
----------------
Constant doesn't imply ConstantInt.  (For example, it could be the address of a global variable.)

Not sure you need to explicitly check for constants here, anyway; Builder.CreateZExt does constant folding.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103082/new/

https://reviews.llvm.org/D103082