[PATCH] D103634: [BitcodeWriter][PowerPC] Avoid clearing lower bits for ppc_fp128 NullValues
Jinsong Ji via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 3 11:33:12 PDT 2021
jsji added a comment.
In D103634#2797005 <https://reviews.llvm.org/D103634#2797005>, @efriedma wrote:
> Constant::isNullValue() is supposed to mean "is this value all zero bits"; various parts of the code use it that way. It shouldn't care whether the value is semantically equal to zero. Anything doing floating-point arithmetic should be using the appropriate ConstantFP/APFloat methods.
Oh... Thanks for the info, I will check and update.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103634/new/
https://reviews.llvm.org/D103634
More information about the llvm-commits
mailing list