[llvm] a8099b4 - Remove redundant Begin/End form signpost format strings.

[Adrian Prantl via llvm-commits]

Author: Adrian Prantl
Date: 2021-06-03T11:24:13-07:00
New Revision: a8099b477832cb8325e1a06d8a2a821949fccde0

URL: https://github.com/llvm/llvm-project/commit/a8099b477832cb8325e1a06d8a2a821949fccde0
DIFF: https://github.com/llvm/llvm-project/commit/a8099b477832cb8325e1a06d8a2a821949fccde0.diff

LOG: Remove redundant Begin/End form signpost format strings.

The os_signpost API already captures the begin/end part and in
Instruments, this just adds visual noise that gets in the way of the
interesting data. By removing the redundant end text, the display in
Instruments gets even less cluttered.

rdar://78636200

Differential Revision: https://reviews.llvm.org/D103577

Added: 
    

Modified: 
    llvm/lib/Support/Signposts.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Support/Signposts.cpp b/llvm/lib/Support/Signposts.cpp
index 37e16a99f46b..7bf7b46c1047 100644
--- a/llvm/lib/Support/Signposts.cpp
+++ b/llvm/lib/Support/Signposts.cpp
@@ -74,7 +74,7 @@ class SignpostEmitterImpl {
       if (SIGNPOSTS_AVAILABLE()) {
         // Both strings used here are required to be constant literal strings.
         os_signpost_interval_begin(getLogger(), getSignpostForObject(O),
-                                   "LLVM Timers", "Begin %s", Name.data());
+                                   "LLVM Timers", "%s", Name.data());
       }
     }
   }
@@ -84,7 +84,7 @@ class SignpostEmitterImpl {
       if (SIGNPOSTS_AVAILABLE()) {
         // Both strings used here are required to be constant literal strings.
         os_signpost_interval_end(getLogger(), getSignpostForObject(O),
-                                 "LLVM Timers", "End %s", Name.data());
+                                 "LLVM Timers", "");
       }
     }
   }