[PATCH] D103304: Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|[runtime]|always).

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka accepted this revision.
vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_rtl.cpp:39-48
+// Instrumented code can set this value in terms of -asan_use_after_return
+// * 0: never (__asan_detect_use_after_return_always does NOT get created)
+//    Yes, that means there is some useless code that runs in AsanThread if the
+//    runner of the binary provides ASAN_OPTIONS=detect_stack_use_after_return.
+//    The useless code will be improved with late-initialization of the fake
+//    stack.
+// * undefined or 1: determined at runtime by
----------------
This comment explain more instrumented code.
I'd rather inverted it:
__asan_detect_use_after_return_always is undefined: all instrumented modules either compiled with asan_use_after_return 1 or 0
__asan_detect_use_after_return_always is defined: at least one of modules compiled with asan_use_after_return 2


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103304/new/

https://reviews.llvm.org/D103304