[PATCH] D103582: [AArch64][GlobalISel] Handle multiple phis in fixupPHIOpBanks

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 3 10:21:31 PDT 2021


aemerson added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp:6012
+      if (InsertPt != OpDefBB.end() && InsertPt->isPHI())
+        InsertPt = OpDefBB.getFirstNonPHI();
+      MIB.setInsertPt(*OpDef->getParent(), InsertPt);
----------------
Can we simply use getFirstNonPHI() unconditionally?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103582/new/

https://reviews.llvm.org/D103582



More information about the llvm-commits mailing list