[PATCH] D99354: [SimpleLoopUnswitch] Port partially invariant unswitch from LoopUnswitch to SimpleLoopUnswitch

Thu Jun 3 09:02:04 PDT 2021

jonpa added a comment.

In D99354#2795599 <https://reviews.llvm.org/D99354#2795599>, @jaykang10 wrote:

> In D99354#2794815 <https://reviews.llvm.org/D99354#2794815>, @jonpa wrote:
>
>> Great to see progress on this :-)
>>
>> I don't see the speedup on omnetpp that we saw before on SystemZ. Do I need to pass some option or adjust some target threshold value somewhere?
>
> @jonpa Thanks for checking the performance number on SystemZ.
>
> I was able to see the speed up on omnetpp of SPEC2006 but there was no speedup on omentpp of SPEC2017. I guess you are looking SPEC2017 one.

yes

> It seemed there is different inlining between new pass manager and legacy pass manager and it causes to reduce partial loop unswitch opportunities on omnetpp of SPEC2017.
>
> I am trying to get the speedup with the partial loop unswitch on omnetpp of SPEC2017 again. Once I fix it, I will let you know.

awesome!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99354/new/

https://reviews.llvm.org/D99354