[PATCH] D102391: [AMDGPU][GlobalISel] Legalize G_ABS

[Jay Foad via Phabricator via llvm-commits]

foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

LGTM.

> Maybe rename lowerAbs to lowerAbsToAshrAddXor or lowerAbsToAddXor?

Maybe call them `lowerAbsToAddXor` and `lowerAbsToMaxNeg`?



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:2333
+    // max combination.
+    if ((SrcBank && SrcBank == &AMDGPU::VGPRRegBank)) {
+      MachineFunction *MF = MI.getParent()->getParent();
----------------
Too many parentheses.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102391/new/

https://reviews.llvm.org/D102391