[PATCH] D93659: [AIX][XCOFF] emit vector info of traceback table.

[Jason Liu via Phabricator via llvm-commits]

jasonliu added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineRegisterInfo.h:857
+  bool isPhysRegModified(MCRegister PhysReg, bool SkipNoReturnDef = false,
+                         bool SkipTestUsedPhysRegMask = false) const;
 
----------------
If this is necessary, could we add a test case for it? Right now, even setting the third parameter to always be false, I don't see any lit failing. 


================
Comment at: llvm/lib/Target/PowerPC/PPCMachineFunctionInfo.h:123
+  /// HasVectorParms - True if ther are vector parameters
+  bool HasVectorParms = false;
 
----------------
Do you need to store this info? 
For hasVectorParms() function, could you do `return VectorParmsNum;` instead? Or you could also get rid of that function and use `getVectorParmsNum() != 0`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93659/new/

https://reviews.llvm.org/D93659