[PATCH] D102973: [ELF] Suppress GRP_COMDAT deduplication if the signature symbol is STB_LOCAL

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added inline comments.


================
Comment at: lld/test/ELF/comdat-local.s:14-16
+# CHECK-NEXT: [[#%x,_:]] 0202
+# CHECK:      Hex dump of section '.comdat':
+# CHECK-NEXT: [[#%x,_:]] 0101
----------------
thopre wrote:
> jhenderson wrote:
> > Aside: @thopre, it would be nice if FileCheck would allow this pattern without the need to name the variable something ("_" in this case). The ideal format would be `[[#%x]]` indicating match any hex format value, much like `[[#]]` matches any default-format (i.e. decimal) number.
> It's already possible:
> 
> 
> ```
> % cat chk 
> CHECK: FOO[[#%X,]]R
> % echo "FOOBAR" | ./bin/FileCheck chk; echo $?
> 0
> ```



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102973/new/

https://reviews.llvm.org/D102973