[PATCH] D102969: [GlobalISel] Add G_SBFX/G_UBFX to computeKnownBits

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with one minor - cheers.



================
Comment at: llvm/lib/CodeGen/GlobalISel/GISelKnownBits.cpp:119
+// objects.
+static KnownBits extractBits(unsigned BitWidth, const KnownBits &SrcOpKnown,
+                             const KnownBits &OffsetKnown,
----------------
Please can you add a TODO suggesting we move this to KnownBits.h - it looks like this might be usable in other places (e.g. x86 BEXTR) in the future but until then its fine to keep it here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102969/new/

https://reviews.llvm.org/D102969