[PATCH] D103536: [CodeGen] Fix a scalable-vector crash in VSELECT legalization

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck marked an inline comment as done.
frasercrmck added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:4258
+
+  // This method can't handle scalable vector types.
+  if (VSelVT.isScalableVector())
----------------
sdesmalen wrote:
> nit: Can you add a FIXME to say that this support could be added in the future?
> (or append "yet" after "vector types" in your current comment)
Aye, I've just done so. I originally had a "yet" but didn't want it to just become some stale comment if there were no plans to change it. Do you think AArch64 may have a use for this function?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103536/new/

https://reviews.llvm.org/D103536