[PATCH] D103536: [CodeGen] Fix a scalable-vector crash in VSELECT legalization

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 3 00:52:56 PDT 2021


sdesmalen added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:4258
+
+  // This method can't handle scalable vector types.
+  if (VSelVT.isScalableVector())
----------------
nit: Can you add a FIXME to say that this support could be added in the future?
(or append "yet" after "vector types" in your current comment)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103536/new/

https://reviews.llvm.org/D103536



More information about the llvm-commits mailing list