[PATCH] D102901: [HWASAN] Update pointer tag for X86_64

[Matt Morehouse via Phabricator via llvm-commits]

morehouse added inline comments.


================
Comment at: llvm/test/Instrumentation/HWAddressSanitizer/X86/stack.ll:5
+
+source_filename = "stack.c"
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
----------------
xiangzhangllvm wrote:
> morehouse wrote:
> > morehouse wrote:
> > > Instead of making a new test, can we reuse the alloca tests for aarch64 and update the expected instrumentation?
> > I see this test is gone now, but I don't see any alloca tests copied into the X86 directory.  Maybe you forgot to add them in the patch?
> Did you mean the llvm/test/Instrumentation/HWAddressSanitizer/alloca.ll ? 
> It already at the parent directory of this test (llvm/test/Instrumentation/HWAddressSanitizer/X86)
> So, the check-all can test it.
I meant that one and the other tests with alloca in the name.  Those are testing instrumentation for aarch64.  I want to also check the instrumentation for them on x86, since we have differences between the architectures.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102901/new/

https://reviews.llvm.org/D102901