[PATCH] D103560: [flang] Check for duplicate definitions of defined input/output procedures

[Peter Klausler via Phabricator via llvm-commits]

klausler accepted this revision.
klausler added inline comments.
This revision is now accepted and ready to land.


================
Comment at: flang/lib/Semantics/check-declarations.cpp:1769
+  seenDefinedIoTypes_.emplace_back(
+      TypeWithDefinedIo{derivedType, ioKind, proc});
+}
----------------
I think you don't need or even want the `TypeWithDefinedIo` constructor here; just list the arguments.  Otherwise it's a copy of a constructed value, not construction in place.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103560/new/

https://reviews.llvm.org/D103560