[PATCH] D103355: [InstrProfiling] Delete linkage/visibility toggling for Windows

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Thanks for adding these excellent tests. Lgtm as well.



================
Comment at: compiler-rt/test/profile/Linux/coverage-linkage.cpp:39
+static void internal() { puts("internal"); }
+__attribute__((noinline)) inline void inline_() { puts("inline"); }
+
----------------
Consider leaving a brief note explaining how `__attribute__((noinline)) inline` affects linkonce_odr -- this may look confusing to some readers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103355/new/

https://reviews.llvm.org/D103355