[PATCH] D102894: [SystemZ] Emit .gnu_attribute for an externally visible vector abi.

[Jonas Paulsson via Phabricator via llvm-commits]

jonpa updated this revision to Diff 349367.
jonpa added reviewers: logan, falstaff84, ABataev, flip1995, john.brawn, fhahn.
jonpa added a comment.
Herald added subscribers: jdoerfert, mgrang.

A new class MCTargetELFAttributesStreamer which contains parts taken from ARMTargetELFStreamer for emitting an attributes section. This works by using multiple inheritance so that the MCTargetStreamers that need this can derive from this new class as well (is multiple inheritance ok to use, or should it be avoided?)

SystemZAsmParser extended to handle .gnu_attribute 8, ...

This does not care about the Tag value in any other way than integer '8'. For ARM build-attributes, it e.g. is possible to do

  bin/llvm-readelf --arch-specific tc_arm.s.o -
  
  File: tc_arm.s.o
  BuildAttributes {
    FormatVersion: 0x41
    Section 1 {
      SectionLength: 17
      Vendor: aeabi
      Tag: Tag_File (0x1)
      Size: 7
      FileAttributes {
        Attribute {
          Tag: 23
          Value: 3
          TagName: ABI_FP_number_model
          Description: IEEE-754
        }
      }
    }
  }

Should this also be implemented for SystemZ/GNU-attributes now?

Adding more reviers with the hope to get feedback on the common code changes...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102894/new/

https://reviews.llvm.org/D102894

Files:
  llvm/include/llvm/MC/MCStreamer.h
  llvm/lib/MC/MCStreamer.cpp
  llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp
  llvm/lib/Target/SystemZ/AsmParser/SystemZAsmParser.cpp
  llvm/lib/Target/SystemZ/MCTargetDesc/SystemZMCTargetDesc.cpp
  llvm/lib/Target/SystemZ/SystemZAsmPrinter.cpp
  llvm/lib/Target/SystemZ/SystemZAsmPrinter.h
  llvm/lib/Target/SystemZ/SystemZTargetStreamer.h
  llvm/test/CodeGen/SystemZ/vec-abi-gnuattr-00.ll
  llvm/test/CodeGen/SystemZ/vec-abi-gnuattr-01.ll
  llvm/test/CodeGen/SystemZ/vec-abi-gnuattr-02.ll
  llvm/test/CodeGen/SystemZ/vec-abi-gnuattr-03.ll
  llvm/test/CodeGen/SystemZ/vec-abi-gnuattr-04.ll
  llvm/test/CodeGen/SystemZ/vec-abi-gnuattr-05.ll
  llvm/test/CodeGen/SystemZ/vec-abi-gnuattr-06.ll
  llvm/test/CodeGen/SystemZ/vec-abi-gnuattr-07.ll
  llvm/test/CodeGen/SystemZ/vec-abi-gnuattr-08.ll
  llvm/test/CodeGen/SystemZ/vec-abi-gnuattr-09.ll
  llvm/test/CodeGen/SystemZ/vec-abi-gnuattr-10.ll
  llvm/test/MC/SystemZ/gnu-attributes.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102894.349367.patch
Type: text/x-patch
Size: 32487 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210602/06cd3681/attachment.bin>