[PATCH] D103269: [RISCV] Reserve an emergency spill slot for any RVV spills

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-emergency-slot.mir:1
+# NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+# RUN: llc -mtriple riscv64 -mattr=+experimental-v -start-before=prologepilog -o - \
----------------
HsiangKai wrote:
> frasercrmck wrote:
> > HsiangKai wrote:
> > > I am not sure what is the difference between update_llc_test_checks.py and update_mir_test_checks.py. I see most of the MIR tests are updated by update_mir_test_checks.py. Just curious why this file is updated by update_llc_test_checks.py.
> > I'm not 100% on this, but I believe `update_mir_test_checks.py` will only add checks to the MIR, like when coming from `-run-pass` or `-stop-after`. You still need `update_llc_test_checks.py` if you want to check the asm.
> > 
> > This particular test was copied from `out-of-each-emergency-slot.mir` which checks the resulting asm.
> Got it. Thanks for your explanation.
Yeah, it's about what type of output llc is producing, as the different tools use different patterns to capture the relevant output lines for CHECK lines. So IR->MIR and MIR->MIR use mir, whereas IR->asm and MIR->asm use llc. The confusion stems from the fact that, unlike C->IR->IR->asm, where you have clear cc1/opt/llc steps, llc gets used for both IR and MIR production. The names could perhaps be clearer, but I suspect update_mir_test_checks.py came after update_llc_test_checks.py already existed (see also update_test_checks.py which is for opt, that I assume came before all the others, and so has an even more confusing name; ideally it'd be a smart wrapper around all the others, with a dedicated update_opt_test_checks.py...).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103269/new/

https://reviews.llvm.org/D103269