[PATCH] D103441: [SLP] Avoid std::stable_sort(properlyDominates()).

Harald van Dijk via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 2 11:17:55 PDT 2021


hvdijk added inline comments.


================
Comment at: llvm/test/Transforms/SLPVectorizer/X86/ordering-bug.ll:1
+; RUN: opt -mtriple=i386-linux-gnu -slp-vectorizer -S %s | FileCheck %s
+
----------------
RKSimon wrote:
> Self generated checks are a pain to maintain (especially in an actively changing component like SLP) - what does it look like if you use the llvm\utils\update_test_checks.py script?
It's weird in how it handles block labels, see update. If that makes it much easier to maintain though, it may still be worth it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103441/new/

https://reviews.llvm.org/D103441



More information about the llvm-commits mailing list