[PATCH] D103542: Fix dfsan handling of musttail calls.

Wed Jun 2 11:10:37 PDT 2021

stephan.yichao.zhao added a subscriber: gbalats.
stephan.yichao.zhao added inline comments.

================
Comment at: llvm/test/Instrumentation/DataFlowSanitizer/musttailcall.ll:4
+; RUN: opt < %s -dfsan -dfsan-fast-8-labels -S | FileCheck %s
+; RUN: opt < %s -dfsan -dfsan-fast-16-labels -dfsan-track-origins=1 -S | FileCheck %s --check-prefixes=CHECK,CHECK_ORIGIN
+target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"
----------------
@gbalats: FYI for removing the non-fast-8-test from the new test.

================
Comment at: llvm/test/Instrumentation/DataFlowSanitizer/musttailcall.ll:8-12
+; CHECK-LABEL: @__dfsan_arg_tls
+; CHECK: = external thread_local(initialexec) global [100 x i64]
+
+; CHECK-LABEL: @__dfsan_retval_tls
+; CHECK: = external thread_local(initialexec) global [100 x i64]
----------------
Please remove the pattern check because this test is not related.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103542/new/

https://reviews.llvm.org/D103542