[PATCH] D103300: [Debug-Info] handle DW_CC_pass_by_value/DW_CC_pass_by_reference under strict DWARF.

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.

Looks alright. Test might be tidied up a bit I think.



================
Comment at: llvm/test/DebugInfo/Generic/pass-by-value.ll:27
+; STRICT: DW_TAG_structure_type
+; STRICT-NOT: DW_AT_calling_convention	(DW_CC_pass_by_reference)
+; STRICT-NEXT: DW_AT_name	("S")
----------------
I'd probably relax this to: `STRICT-NOT: DW_AT_calling_convention` (& similarly below)

Or maybe even implicit-check-not=DW_AT_calling_convention in the FileCheck line above?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103300/new/

https://reviews.llvm.org/D103300