[PATCH] D103515: [VPlan] Print successors of VPRegionBlocks.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 2 08:47:07 PDT 2021
fhahn added a comment.
In D103515#2793821 <https://reviews.llvm.org/D103515#2793821>, @a.elovikov wrote:
> Looks good to me. Thanks for following up on that.
>
>> I think the printing of successors could be a bit improved further, as at the moment it is hard to ensure a check line matches all successors.
>
> What do you mean by that?
Currently I am not sure how to best write a CHECK-line that will fail if a new successor gets added, e.g. `CHECK: Successor(s): if.then.0` will also pass if an additional successor gets added. Perhaps we should just include the number of successors, something like `1 Successor: if.then`, or `3 Successors: a, b, c`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103515/new/
https://reviews.llvm.org/D103515
More information about the llvm-commits
mailing list