[PATCH] D103120: LTO: Export functions referenced by non-canonical CFI jump tables

[Sami Tolvanen via Phabricator via llvm-commits]

samitolvanen added inline comments.


================
Comment at: llvm/test/LTO/Resolution/X86/export-jumptable-noncanonical.ll:13
+; CHECK: define void @f1()
+define void @f1() !type !0 {
+  ret void
----------------
tejohnson wrote:
> I assume this is part of a non-canonical jump table, which is why we don't internalize with this patch. How can I tell that it is part of a non-canonical rather than canonical jump table?
> I assume this is part of a non-canonical jump table, which is why we don't internalize with this patch. How can I tell that it is part of a non-canonical rather than canonical jump table?

Correct. The "CFI Canonical Jump Tables" module flag is set to 0 at the bottom of the file to use non-canonical jump tables.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103120/new/

https://reviews.llvm.org/D103120