[PATCH] D103180: [InstSimplify] Add constant fold for extractelement + splat for scalable vectors
Caroline via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 2 07:58:39 PDT 2021
CarolineConcatto marked an inline comment as done.
CarolineConcatto added a comment.
In D103180#2782981 <https://reviews.llvm.org/D103180#2782981>, @spatel wrote:
> In D103180#2782861 <https://reviews.llvm.org/D103180#2782861>, @foad wrote:
>
>> Thanks for splitting it up. I like small patches.
>
> Definitely agree. :)
>
> For the test where the index is presumed invalid (i32 -1), is that enforced somehow? Is there a hard limit somewhere that says i32 0xffffffff must be invalid?
Sorry, @spatel
I've missed your comment above
I think the reason it says is invalid is because of the test:
uge(ValSVTy->getMinNumElements() -> unsigned greater or equal
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103180/new/
https://reviews.llvm.org/D103180
More information about the llvm-commits
mailing list