[PATCH] D103167: [ARM] Fix Machine Outliner LDRD/STRD handling in Thumb mode

[Momchil Velikov via Phabricator via llvm-commits]

chill added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:6001
   default:
     llvm_unreachable("Unsupported addressing mode!");
   }
----------------
yroux wrote:
> yroux wrote:
> > chill wrote:
> > > Can't we instead `return false;` here and get rid of enumerating all unsupported addressing modes on line 5933?
> > hmm, yes I agree it'll make it easier to read
> The issue is that getting the offset value line 5948 can only be done if the addressing mode has one, so we can't get rid of the checking line 5933.  I already planned to rework this part and extract it since that kind of logic is used in multiple places in the backend, but what about keeping it as it for this bugfix ?
Agree, it's a separate concern.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103167/new/

https://reviews.llvm.org/D103167