[PATCH] D103407: [TTI] NFC: Change getNumberOfParts to return InstructionCost.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 2 05:37:03 PDT 2021


sdesmalen added a comment.

This change doesn't make much sense to me, `getNumberOfParts` returns how many pieces to split up the provided type. If the answer is unknown the value 0 is used for that, so there shouldn't be a reason why this would ever need to return Invalid.
Additionally, all current uses of this function are in the SLPVectorizer and the SystemZ target where vector types are fixed, so it should always be possible to split a type in a known number of parts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103407/new/

https://reviews.llvm.org/D103407



More information about the llvm-commits mailing list