[PATCH] D99438: [SimplifyLibCalls] Take size of int into consideration when emitting ldexp/ldexpf

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 2 04:10:29 PDT 2021


bjope added a comment.

In D99438#2793153 <https://reviews.llvm.org/D99438#2793153>, @xbolva00 wrote:

> Commited without approval?

Ah, right. I missed that when pushing the approved patches that depended on this one.

Maybe we can have a post-commit review of this.
IMHO this is a quite straight forward fix. Nobody has expressed any major concern about the actual solution for 2 months (it has plenty of reviewers and this has been brought up on llvm-dev).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99438/new/

https://reviews.llvm.org/D99438



More information about the llvm-commits mailing list