[PATCH] D103497: [lld/mac] Implement -reexport_framework, -reexport_library, -reexport-l

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Thanks!



================
Comment at: lld/MachO/Driver.cpp:335-336
+      if (isReexport) {
+        config->hasReexports = true;
+        dylibFile->reexport = true;
+      }
----------------
int3 wrote:
> How about having a setter on DylibFile that sets both `reexport` and `config->hasReexports`?
> 
> (if you do add it, `markReexport()` can use it too)
I was planning on deleting `config->hasReexports` and computing it by walking over all dylib files in the one place we need it in a follow-up. (I need to add some tests around the interaction of dead_strip_dylibs and reexports, too.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103497/new/

https://reviews.llvm.org/D103497