[PATCH] D99354: [SimpleLoopUnswitch] Port partially invariant unswitch from LoopUnswitch to SimpleLoopUnswitch

[JinGu Kang via Phabricator via llvm-commits]

jaykang10 added a comment.

In D99354#2793045 <https://reviews.llvm.org/D99354#2793045>, @fhahn wrote:

> LGTM thanks, with the additional suggestions for the tests.

Thanks @fhahn! After updating tests, I will push it.



================
Comment at: llvm/test/Transforms/SimpleLoopUnswitch/partial-unswitch-check-metadata.ll:9
+
+define i32 @partial_unswitch_check_metadata(i32* %ptr, i32 %N) {
+; CHECK-LABEL: @partial_unswitch_check_metadata(
----------------
fhahn wrote:
> Can this test just be part of llvm/test/Transforms/SimpleLoopUnswitch/partial-unswitch.ll?
Yep, I will add the metadata check in llvm/test/Transforms/SimpleLoopUnswitch/partial-unswitch.ll.


================
Comment at: llvm/test/Transforms/SimpleLoopUnswitch/partial-unswitch-generate-metadata.ll:8
+;
+; CHECK: [[LOOP0:![0-9]+]] = !{!"llvm.loop.unswitch.partial.disable"}
+
----------------
fhahn wrote:
> can you also include checks for the generated IR, ensuring that the whole metadata chain is correct (!llvm.loop attached to the right unswitched loop and contains the disable metadata? Also, can this just be part of `llvm/test/Transforms/SimpleLoopUnswitch/partial-unswitch.ll`? I think we can just extend the checks there, rather than adding a new file + function.
Yep, I will add the metadata check in llvm/test/Transforms/SimpleLoopUnswitch/partial-unswitch.ll.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99354/new/

https://reviews.llvm.org/D99354