[PATCH] D103269: [RISCV] Reserve an emergency spill slot for any RVV spills
Fraser Cormack via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 2 02:44:53 PDT 2021
frasercrmck added a comment.
In D103269#2792902 <https://reviews.llvm.org/D103269#2792902>, @HsiangKai wrote:
> Add `Subtarget.hasStdExtV()` checking to avoid the impact on non-V code is a good idea.
An interesting case shows up where the MIR test I added in this patch contains RVV instructions but doesn't pass `-mattr=+experimental-v` so the subtarget reports that `hasStdExtV` is false. It's presumably the user's responsibility to correctly pass `mattr` even with MIR. Though through this I've identified other tests like `rvv/zvlsseg-copy.mir` which don't pass `-mattr` either.
Assuming I've got this right, we should go through the MIR tests and make sure they pass the correct attrs. Something to keep in mind for future reviews.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103269/new/
https://reviews.llvm.org/D103269
More information about the llvm-commits
mailing list