[PATCH] D99481: [InstCombine] Fix miscompile on GEP+load to icmp fold (PR45210)

Mindong Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 1 23:48:23 PDT 2021


mdchen added a comment.

@lebedev.ri

> It fails even if i bump those limits to 0.1M iterations.
> This is clearly an infinite combine cycle.

If that's the case, isn't it more reasonable to replace the `fatal_error` with `assert` so that only developers sense that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99481/new/

https://reviews.llvm.org/D99481



More information about the llvm-commits mailing list