[PATCH] D103505: [lld][MachO] Add first bits to support special symbols

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 1 23:02:18 PDT 2021


alexshap added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:999-1000
+    llvm::VersionTuple cVersion;
+    if (cVersion.tryParse(compatVersion))
+      return false;
+    compatibilityVersion = encodeVersion(cVersion);
----------------
int3 wrote:
> ditto, I think we should log a warning here (and test for it)
yup, i think a warning would be useful


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103505/new/

https://reviews.llvm.org/D103505



More information about the llvm-commits mailing list