[PATCH] D103328: [CodeGen][NFC] Remove unused virtual function

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu updated this revision to Diff 349172.
myhsu added a comment.

Rename `M68kFrameLowering::emitCalleeSavedFrameMoves` with 3 args into another name to avoid confusion


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103328/new/

https://reviews.llvm.org/D103328

Files:
  llvm/include/llvm/CodeGen/TargetFrameLowering.h
  llvm/lib/Target/M68k/M68kFrameLowering.cpp
  llvm/lib/Target/M68k/M68kFrameLowering.h
  llvm/lib/Target/X86/X86FrameLowering.h


Index: llvm/lib/Target/X86/X86FrameLowering.h
===================================================================
--- llvm/lib/Target/X86/X86FrameLowering.h
+++ llvm/lib/Target/X86/X86FrameLowering.h
@@ -65,8 +65,7 @@
 
   void emitCalleeSavedFrameMoves(MachineBasicBlock &MBB,
                                  MachineBasicBlock::iterator MBBI,
-                                 const DebugLoc &DL,
-                                 bool IsPrologue) const override;
+                                 const DebugLoc &DL, bool IsPrologue) const;
 
   /// emitProlog/emitEpilog - These methods insert prolog and epilog code into
   /// the function.
Index: llvm/lib/Target/M68k/M68kFrameLowering.h
===================================================================
--- llvm/lib/Target/M68k/M68kFrameLowering.h
+++ llvm/lib/Target/M68k/M68kFrameLowering.h
@@ -57,10 +57,9 @@
   void BuildCFI(MachineBasicBlock &MBB, MachineBasicBlock::iterator MBBI,
                 const DebugLoc &DL, const MCCFIInstruction &CFIInst) const;
 
-  void emitCalleeSavedFrameMoves(MachineBasicBlock &MBB,
-                                 MachineBasicBlock::iterator MBBI,
-                                 const DebugLoc &DL,
-                                 bool IsProlog) const override;
+  void emitPrologueCalleeSavedFrameMoves(MachineBasicBlock &MBB,
+                                         MachineBasicBlock::iterator MBBI,
+                                         const DebugLoc &DL) const;
 
   unsigned getPSPSlotOffsetFromSP(const MachineFunction &MF) const;
 
Index: llvm/lib/Target/M68k/M68kFrameLowering.cpp
===================================================================
--- llvm/lib/Target/M68k/M68kFrameLowering.cpp
+++ llvm/lib/Target/M68k/M68kFrameLowering.cpp
@@ -447,9 +447,9 @@
       .addCFIIndex(CFIIndex);
 }
 
-void M68kFrameLowering::emitCalleeSavedFrameMoves(
+void M68kFrameLowering::emitPrologueCalleeSavedFrameMoves(
     MachineBasicBlock &MBB, MachineBasicBlock::iterator MBBI,
-    const DebugLoc &DL, bool IsProlog) const {
+    const DebugLoc &DL) const {
   MachineFunction &MF = *MBB.getParent();
   MachineFrameInfo &MFI = MF.getFrameInfo();
   MachineModuleInfo &MMI = MF.getMMI();
@@ -656,7 +656,7 @@
 
     // Emit DWARF info specifying the offsets of the callee-saved registers.
     if (PushedRegs)
-      emitCalleeSavedFrameMoves(MBB, MBBI, DL, true);
+      emitPrologueCalleeSavedFrameMoves(MBB, MBBI, DL);
   }
 
   // TODO Interrupt handlers
Index: llvm/include/llvm/CodeGen/TargetFrameLowering.h
===================================================================
--- llvm/include/llvm/CodeGen/TargetFrameLowering.h
+++ llvm/include/llvm/CodeGen/TargetFrameLowering.h
@@ -215,11 +215,6 @@
   emitCalleeSavedFrameMoves(MachineBasicBlock &MBB,
                             MachineBasicBlock::iterator MBBI) const {}
 
-  virtual void emitCalleeSavedFrameMoves(MachineBasicBlock &MBB,
-                                         MachineBasicBlock::iterator MBBI,
-                                         const DebugLoc &DL,
-                                         bool IsPrologue) const {}
-
   /// Replace a StackProbe stub (if any) with the actual probe code inline
   virtual void inlineStackProbe(MachineFunction &MF,
                                 MachineBasicBlock &PrologueMBB) const {}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103328.349172.patch
Type: text/x-patch
Size: 3333 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210602/4cb777d3/attachment.bin>