[PATCH] D103354: [test-suite] Decouple Fortran tests from C/C++ tests.

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

Ideally, how a test is executed is entirely specified in one file (the CMakeLists.txt), instead split between two files. In the standard case, a `lit.local.cfg` should not be required.

I don't expect a redesign of the build system, so LGTM.



================
Comment at: Fortran/UnitTests/hello/lit.local.cfg:1
+config.traditional_output = True
+config.single_source = True
----------------
With `config.traditional_output`, stderr, stdout and the error code are implicitly redirected to a `.out` file . If false, the stderr/stdout files are specified explicitly. I think it is meant as a compatibility switch to make rewriting the build to CMake easier.



================
Comment at: Fortran/UnitTests/hello/lit.local.cfg:2
+config.traditional_output = True
+config.single_source = True
----------------
`config.single_source` is used for the "compiletime" and "stats" plugin to find the compile'r auxiliary output files. This is already unreliable (e.g. they ignore the CMake PREFIX argument, because the lit cfg has not idea what the PREFIX argument in the CMakeLists.txt is). This does need an overhaul.


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103354/new/

https://reviews.llvm.org/D103354