[PATCH] D103355: [InstrProfiling] Delete linkage/visibility toggling for Windows

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: compiler-rt/test/profile/Windows/coverage-weak-lld.cpp:63
+// PROFILE2-NEXT:    Counters: 1
+// PROFILE2-NEXT:    Function count: 2
+
----------------
@rnk The behavior change of this patch is here: previously this is 0 (similar to the PROFILE1 case). It is now 2 (like ELF) because the counter is weak and resolves to the %t0.o copy.

I think this doesn't matter because (1) the new behavior matches ELF (2) weak overriding weak is a mingw extension, not supported by link.exe.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103355/new/

https://reviews.llvm.org/D103355