[PATCH] D103428: [lld/mac] Make -t work correctly with -flat_namespace

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 1 16:35:28 PDT 2021


thakis added a comment.

In D103428#2791973 <https://reviews.llvm.org/D103428#2791973>, @int3 wrote:

> I'd prefer we put in in the ctors: I agree that having side-effects in a constructor is a bit weird, but OTOH it means that we'll never have to worry about new instantiation sites forgetting to add this logging.

I just realized I landed this without addressing this comment. Sorry, that wasn't intentional, I just forgot. I'll fix it up in a follow-up commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103428/new/

https://reviews.llvm.org/D103428



More information about the llvm-commits mailing list