[PATCH] D99812: [PowerPC] [GlobalISel] Implementation of formal arguments lowering in the IRTranslator for the PPC backend

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 1 16:13:56 PDT 2021


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with style nit



================
Comment at: llvm/lib/Target/PowerPC/GISel/PPCCallLowering.cpp:118
+      LLT::pointer(0,
+                   MIRBuilder.getMF().getDataLayout().getPointerSizeInBits()),
+      FI);
----------------
Use a variable and less indentation?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99812/new/

https://reviews.llvm.org/D99812



More information about the llvm-commits mailing list