[PATCH] D103489: [lld-macho][nfc] Remove unnecessary use of Optional<T*>

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 1 15:35:06 PDT 2021


oontvoo added a comment.

In D103489#2792029 <https://reviews.llvm.org/D103489#2792029>, @thakis wrote:

> I guess the idea was that the Optional forces you to "null" check, while the pointer doesn't? Fine to land if you want, but fine to not land too imho.



In D103489#2792127 <https://reviews.llvm.org/D103489#2792127>, @int3 wrote:

> I like the safety that `Optional<T*>` gives, but I'm also aware that we aren't consistent about using it in our codebase (and I like consistency), so I'm fine with this

Thanks! IMO, null is already a sentinel value, so why not use it? :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103489/new/

https://reviews.llvm.org/D103489



More information about the llvm-commits mailing list