[PATCH] D103488: [lld/mac] Emit only one LC_LOAD_DYLIB per dylib

[Nico Weber via Phabricator via llvm-commits]

thakis marked 3 inline comments as done.
thakis added a comment.

Thanks!



================
Comment at: lld/test/MachO/dylink-ordinal.s:6-23
+# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/main.s -o %t/main.o
+# RUN: %lld -o %t/main -L%t -lFoo -lBar -lSystem %t/main.o
+# RUN: llvm-objdump --lazy-bind -d --no-show-raw-insn %t/main | FileCheck %s
+
+# CHECK: callq 0x[[#%x,FOO_OFF:]]
+# CHECK-NEXT: callq 0x[[#%x,BAR_OFF:]]
+
----------------
int3 wrote:
> are these really necessary? All these pass in the current implementation (only the `LOAD` check below fails)... plus they seem pretty similar to what's already in dylink.s
It's all different places that reference the ordinal – seems nice to have the coverage to me. But feel free to delete the bits you don't like :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103488/new/

https://reviews.llvm.org/D103488