[PATCH] D103408: DetectDeadLanes: Remove assert for subregister defs

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 1 14:50:18 PDT 2021


arsenm added a comment.

In D103408#2792212 <https://reviews.llvm.org/D103408#2792212>, @efriedma wrote:

> I'm not sure this is the right fix.
>
> From my understanding, REG_SEQUENCE, INSERT_SUBREG, EXTRACT_SUBREG, and PHI should never target a subregister.  For COPY, we can target a subregister, but only if that register is a physical register.

Physical registers do not have subregister indexes. TRI::getSubReg resolves the physreg with index to a different physreg value. It's invalid to combine the two


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103408/new/

https://reviews.llvm.org/D103408



More information about the llvm-commits mailing list