[PATCH] D103489: [lld-macho][nfc] Remove unnecessary use of Optional<T*>

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 1 13:14:06 PDT 2021


thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

I guess the idea was that the Optional forces you to "null" check, while the pointer doesn't? Fine to land if you want, but fine to not land too imho.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103489/new/

https://reviews.llvm.org/D103489



More information about the llvm-commits mailing list