[PATCH] D103486: [lld][WebAssemlby] Fix for string merging of -dwarf-5 sections
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 1 12:53:05 PDT 2021
sbc100 updated this revision to Diff 349072.
sbc100 added a comment.
- add bug links
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103486/new/
https://reviews.llvm.org/D103486
Files:
lld/wasm/InputFiles.cpp
Index: lld/wasm/InputFiles.cpp
===================================================================
--- lld/wasm/InputFiles.cpp
+++ lld/wasm/InputFiles.cpp
@@ -368,8 +368,11 @@
// currently go by the name alone.
// TODO(sbc): Add ability for wasm sections to carry flags so we don't
// need to use names here.
- return sec.Name.startswith(".debug_str") ||
- sec.Name.startswith(".debug_line_str");
+ // For now, keep in sync with uses of wasm::WASM_SEG_FLAG_STRINGS in
+ // MCObjectFileInfo::initWasmMCObjectFileInfo which creates these custom
+ // sections.
+ return sec.Name == ".debug_str" || sec.Name == ".debug_str.dwo" ||
+ sec.Name == ".debug_line_str";
}
static bool shouldMerge(const WasmSegment &seg) {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103486.349072.patch
Type: text/x-patch
Size: 746 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210601/913e2e19/attachment.bin>
More information about the llvm-commits
mailing list