[PATCH] D103043: [Internalize] Rename instead of removal if a to-be-internalized comdat has more than one member

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D103043#2791494 <https://reviews.llvm.org/D103043#2791494>, @nickdesaulniers wrote:

> This seems to be causing some build breakage for us when building with thinLTO+PGO: https://github.com/ClangBuiltLinux/linux/issues/1388.
>
>> ld.lld: error: drivers/gpu/drm/amd/amdgpu/amdgpu.lto.o: SHT_SYMTAB_SHNDX has 79582 entries, but the symbol table associated has 79583
>
> Should "the symbol table associated" also have some renaming done, rather than removal?

The diagnostic is about size(.symtab) and size(.symtab_shndx) mismatch, unrelated to what the patch did.

I've commented on https://github.com/ClangBuiltLinux/linux/issues/1388


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103043/new/

https://reviews.llvm.org/D103043