[PATCH] D103279: [flang][openacc] Enforce restriction on attach and detach variables

[Valentin Clement via Phabricator via llvm-commits]

clementval marked an inline comment as done.
clementval added inline comments.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:866
+                context_.Say(designator.source,
+                    "Variable `%s` on the %s clause must be a variable or "
+                    "array with the POINTER or ALLOCATABLE attribute"_err_en_US,
----------------
kiranchandramohan wrote:
> Nit: Would it be better to say the Argument %s instead of Variable %s since variable again occurs in the message?
Right it's nicer to avoid the double occurrences. Thx. 


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:874
+              context_.Say(name.source,
+                  "Variable `%s` on the %s clause must be a variable or "
+                  "array with the POINTER or ALLOCATABLE attribute"_err_en_US,
----------------
kiranchandramohan wrote:
> Nit: Is there a test that hits this path?
Added one. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103279/new/

https://reviews.llvm.org/D103279