[PATCH] D103120: LTO: Export functions referenced by non-canonical CFI jump tables

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

Adding another possible reviewer since @eugenis added these data structures (D34168 <https://reviews.llvm.org/D34168>). With the caveat that I'm not very familiar at all with this CFI transformation, the patch looks ok to me after looking at how cfiFunctionDecls is used. However it would be great to get a review from either @pcc or @eugenis.



================
Comment at: llvm/test/LTO/Resolution/X86/export-jumptable-noncanonical.ll:13
+; CHECK: define void @f1()
+define void @f1() !type !0 {
+  ret void
----------------
I assume this is part of a non-canonical jump table, which is why we don't internalize with this patch. How can I tell that it is part of a non-canonical rather than canonical jump table?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103120/new/

https://reviews.llvm.org/D103120