[PATCH] D102870: [RFC] [WIP] CodeGen: Print/parse LLTs in MachineMemOperands

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 1 09:54:47 PDT 2021


thegameg added a comment.

In general I think the syntax looks fine. Not sure I get how hard it is to get rid of the parenthesis, but if we end up changing many tests, we should probably do it only once.

Suggestion: maybe add a flag to facilitate the test transition for downstream users? (for `CHECK` lines, assuming there would be some tests that check for things like `load 4` instead of `load (s32)`)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102870/new/

https://reviews.llvm.org/D102870



More information about the llvm-commits mailing list